Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test cases that explicitly test Object unserialization #111

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

jaredoconnell
Copy link
Contributor

Changes introduced with this PR

Adds some test cases that test Object unserialization.


By contributing to this repository, I agree to the contribution guidelines.

Copy link

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's great to have unit testing confirm the entire message, just to validate that it looks reasonable and is properly constructed rather than just "somewhere in the string is the word 'parsing' and somewhere is the bad string". But you're verifying the core error condition and the expected identifying name/string, so I'll stop beating you up about style details. Good.

@jaredoconnell
Copy link
Contributor Author

I think it's great to have unit testing confirm the entire message, just to validate that it looks reasonable and is properly constructed rather than just "somewhere in the string is the word 'parsing' and somewhere is the bad string". But you're verifying the core error condition and the expected identifying name/string, so I'll stop beating you up about style details. Good.

I mainly don't want a minor change to the error message to break all of the relevant test cases. This should be enough validation to ensure that all required info is present.

@jaredoconnell jaredoconnell merged commit 070d4b3 into main Jan 8, 2025
3 checks passed
@jaredoconnell jaredoconnell deleted the test-object-unserialization branch January 8, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants